On Tue, 10 May 2022 22:07:47 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:

>> Hi,
>> 
>> May I have this simple example update in the KeyStore specification?
>> 
>> Password protection should be destroyed in the example code in KeyStore 
>> specification. Otherwise, applications may just copy and past the code, and 
>> forget to clean up password protection.
>> 
>> It's a trivial update, and may not worthy of a CSR.  But please let me know 
>> if you would like to have a CSR filed.
>> 
>> Thanks,
>> Xuelei
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Use PasswordProtection

Approved. Although that `mySecretKey` is out of nowhere, but this is just 
example code.

-------------

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8623

Reply via email to