On Wed, 6 Jul 2022 14:04:10 GMT, Weijun Wang <[email protected]> wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> aw shucks - another one
>
> src/java.base/share/classes/java/security/AllPermission.java line 183:
>
>> 181: *
>> 182: * @throws IllegalArgumentException if the permission is not an
>> 183: * {@crypto AllPermission}
>
> Typo, `s/crypto/code/`.
That's what happens when you don't watch your fingers. Fixed.
> src/java.base/share/classes/java/security/CodeSource.java line 307:
>
>> 305: * and {@code null} certificates all imply
>> 306: * the codesource with the location
>> "http://www.example.com/classes/foo.jar";
>> 307: * and {@code null} certificates:
>
> Should the URL in the line above be wrapped in `{@code}`?
JarURLConnection.java has a wrapped URL, but BigInteger.java does not.
I don't know the right answer although I could ask on #javadoc-team.
> src/java.base/share/classes/javax/crypto/CryptoPermissions.java line 135:
>
>> 133: * object is marked as readonly.
>> 134: *
>> 135: * @see isReadOnly
>
> Should be `PermissionCollection#isReadOnly`.
@see `{@link PermissionCollection#isReadOnly}`
-------------
PR: https://git.openjdk.org/jdk/pull/9282
