On Tue, 8 Nov 2022 17:37:26 GMT, Sean Mullan <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> return (abc) to return abc
>
> src/java.base/share/classes/sun/security/x509/CertAttrSet.java line 35:
>
>> 33: * This interface defines a certificate attribute that can be
>> DER-encoded.
>> 34: */
>> 35: public interface CertAttrSet {
>
> Should we rename this to "CertAttr" since I think it now supports a single
> attribute?
Since it only has `encode` now, I'll merge it with `DerEncoder` and remove it
in my next step. Therefore I haven't cared about giving it a better name. I had
thought about including the merge inside this change but there are a lot of
`s/derEncode/encode/` renaming and it's better to be done separately.
-------------
PR: https://git.openjdk.org/jdk/pull/10959
