On Fri, 4 Nov 2022 17:25:16 GMT, Volodymyr Paprotski <d...@openjdk.org> wrote:

>> src/hotspot/share/opto/library_call.cpp line 7036:
>> 
>>> 7034:   assert(r_start, "r array is NULL");
>>> 7035: 
>>> 7036:   Node* call = make_runtime_call(RC_LEAF,
>> 
>> Can we safely change this to `RC_LEAF | RC_NO_FP`?  For the ChaCha20 block 
>> intrinsic I'm working on I've been using that parameter because I'm not 
>> touching the FP registers and that looks to be the case here (though your 
>> intrinsic is a lot more complicated than mine so I may have missed 
>> something).  I believe the GHASH and AES library call routines also call 
>> `make_runtime_call()` in this way.
>
> Makes sense to me, will put it in and re-test (no fp registers anywhere in 
> the intrinsic). Thanks!

done

-------------

PR: https://git.openjdk.org/jdk/pull/10582

Reply via email to