On Thu, 18 May 2023 16:42:45 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comments addressed
>
> src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java
> line 148:
>
>> 146: builder.append(principal.toString());
>> 147: } catch (IllegalArgumentException iae) {
>> 148: builder.append("unparseable X500Principal: " +
>> iae.getMessage());
>
> Throwable.getMessage() may return `null`. I may use iae.toString() instead.
>
> `builder.append("unparseable X500Principal: " + iae);`
`toString` would be called implicitly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1198052098
