On Wed, 31 May 2023 06:27:41 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> test/jdk/sun/security/ssl/SSLEngineImpl/TestBadDNForPeerCA.java line 29: >> >>> 27: * @library /test/lib >>> 28: * @summary SSLEngine throws IAE during parsing of X500Principal >>> 29: * @run main/othervm TestBadDNForPeerCA >> >> Suggestion: >> >> * @run main/othervm TestBadDNForPeerCA >> * @run main/othervm -Djavax.net.debug=all TestBadDNForPeerCA >> >> and then remove the `debug` field. > > When we put in the debug field into the template, it was to allow folks to > quickly add debugging output to their test, but in general it won't be turned > on during regular test runs. I'd like to enable this in the test runs as well; otherwise the changes to `toString` method will not be tested. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1211196467
