On Fri, 11 Aug 2023 16:17:23 GMT, Matthew Donovan <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix exception handling
>> - Fix indentation
>
> test/jdk/sun/security/ssl/SSLEngineImpl/SSLEngineDecodeBadPoint.java line 40:
>
>> 38: public class SSLEngineDecodeBadPoint {
>> 39: static final byte[] clientHello = HexFormat.of().parseHex(
>> 40: "160303013a0100013603031570" +
>
> This may be the github display but this line is indented differently than the
> others.
Thanks for pointing it out, fixed. Apparently my IntelliJ prefers this style of
formatting multiline strings. I wonder if that's configurable.
> test/jdk/sun/security/ssl/SSLEngineImpl/SSLEngineDecodeBadPoint.java line 76:
>
>> 74: eng.wrap(emptyBuf, alert);
>> 75: throw new RuntimeException("Expected wrap to throw");
>> 76: } catch (Exception e) {
>
> Catching `Exception` here will consume the RuntimeException being thrown.
oops, right. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15148#discussion_r1291782404
PR Review Comment: https://git.openjdk.org/jdk/pull/15148#discussion_r1291782566
