Re: RFR: 8319332: Security properties files inclusion [v2]

[Francisco Ferrari Bihurriet]

On Thu, 9 Nov 2023 20:46:31 GMT, Kevin Driver <kdri...@openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with 
>> one additional commit since the last revision:
>> 
>>   8319332: use Path::of(URI) to deal with file URLs
>>   
>>   Instead of the previously introduced FileURLConnection::getFile(), use
>>   Path::of(URI), leaving some file URL corner-cases without relative
>>   imports support.
>>   
>>   Further details in 
>> https://github.com/openjdk/jdk/pull/16483#discussion_r1382111155
>>   
>>   Co-authored-by: Martin Balao <mba...@redhat.com>
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferr...@redhat.com>
>
> src/java.base/share/classes/java/security/Security.java line 34:
> 
>> 32: import java.nio.file.InvalidPathException;
>> 33: import java.nio.file.Path;
>> 34: import java.util.*;
> 
> Wildcard import may be undesirable; include individual classes? I know this 
> is just moving lines, but I thought I'd mention it.

@driverkt: personally, I also prefer avoiding wildcard imports, but please note 
that by removing them, we would end up with 12 for `java.util.*`, 3 for 
`java.io.*`, and 3 for `sun.security.jca.*`:

import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.InputStream;
import java.net.URI;
import java.net.URL;
import java.nio.file.Files;
import java.nio.file.InvalidPathException;
import java.nio.file.Path;
import java.util.Arrays;
import java.util.Collections;
import java.util.Enumeration;
import java.util.HashSet;
import java.util.Hashtable;
import java.util.LinkedList;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Properties;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;

import jdk.internal.access.JavaSecurityPropertiesAccess;
import jdk.internal.access.SharedSecrets;
import jdk.internal.event.EventHelper;
import jdk.internal.event.SecurityPropertyModificationEvent;
import jdk.internal.util.StaticProperty;
import sun.security.jca.GetInstance;
import sun.security.jca.ProviderList;
import sun.security.jca.Providers;
import sun.security.util.Debug;
import sun.security.util.PropertyExpander;


If no further concerns are raised, I will make this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16483#discussion_r1388597897