On Wed, 6 Mar 2024 16:20:43 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/util/Debug.java line 294: >> >>> 292: if (printThreadDetails) { >>> 293: retString = toHexString(Thread.currentThread().threadId()) >>> + "|" + >>> 294: Thread.currentThread().getName() + "|" + >>> formatCaller(); >> >> The thread ID is in decimal in the default string representation of thread, >> also other diagnostic features such as the new thread dump. So I think you >> want to change this to "#" + Thread.currentThread().threadId(). > > Thanks Alan. Today, the TLS `javax.net.debug` logging prints the thread ID in > hex format. I was repeating behaviour seen from that impl. Having > `java.security.debug` output in decimal and the other in hex would prove > confusing. We could consider flipping both to decimal format in a follow on > patch. Change it here, or in a later PR is okay. Main thing is that the logs are confusing then the Thread string is "#<id>" but the TLS debug logs are different. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18084#discussion_r1516059694