On Wed, 5 Jun 2024 19:50:15 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request with a new target
>> base due to a merge or a rebase. The incremental webrev excludes the
>> unrelated changes brought in by the merge/rebase. The pull request contains
>> 13 additional commits since the last revision:
>>
>> - Fix penultimate block length calculation
>>
>> It is not correct to calculate the penultimate block length based on
>> the output array offset, since the output array can include arbitrary
>> user-supplied data.
>>
>> Add a test case to check this fix.
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>> - Extract swapLastTwoBlocks() unified logic
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>> - Merge 'openjdk/master' into JDK-8330843
>> - Apply code-review suggestion
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>> - Improve handling when the token variant is unknown
>>
>> Avoid registering CTS algorithms (those depending on CKM_AES_CTS) when
>> the token CTS variant has not been specified in the configuration. Make
>> NSS an exception, as we know that it uses the CS1 variant.
>>
>> Take advantage to extract a pkcs11.Config::parseEnumEntry() method for
>> a cleaner entry in the main switch statement of pkcs11.Config::parse(),
>> also slightly improving the error message.
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>> - Merge 'openjdk/master' into JDK-8330843
>> - Revert re-arrangement of native methods parameters
>>
>> This reverts commit 0a777e94229723376e1264e87cbf0ba805dc736f, except for
>> the copyright which is retained as 2024.
>>
>> NOTE: new calls of the same methods are retained in the re-arrangement
>> style, as we didn't introduce this re-arrangement, it was already
>> present in most of the calls inside ::implUpdate() and ::implDoFinal().
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>> - Merge 'openjdk/master' into JDK-8330843
>> - 8330842: Add AES CBC with Ciphertext Stealing (CTS) SunPKCS11 tests
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>> - 8330842: Support AES CBC with Ciph...
>
> test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphers.java line 84:
>
>> 82:
>> 83: new CI("AES/CTR/NoPadding", "AES", 3200),
>> 84: new CI("AES/CTS/NoPadding", "AES", 3200),
>
> Add more data sizes, e.g. not multiples of block sizes?
These edge cases are covered by the new `TestCipherTextStealingMultipart`, here
we only wanted to add some cases in line with the CTR addition
(4ce804890912ce7a0002c9e631c4dc699ac33c39).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18898#discussion_r1628366469
