On Tue, 30 Jul 2024 00:48:36 GMT, Hai-May Chao <[email protected]> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8330217
>> - aliasNotInStore not severe
>> - the fix
>
> test/jdk/sun/security/tools/jarsigner/ByAlias.java line 91:
>
>> 89: kt("-delete -alias ee");
>> 90: js("-verify a.jar")
>> 91: .shouldContain("not signed by alias in this keystore");
>
> As this PR changes `aliasNotInStore` no longer a severe warning, suggest
> adding -strict to test the exit code.
Good idea. New commit pushed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19701#discussion_r1697136188
