On Fri, 13 Sep 2024 19:39:04 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > refine wording on DPS getInstance with params exception src/java.base/share/classes/javax/crypto/KDFSpi.java line 95: > 93: * If the required parameters were not supplied and can be generated > by > 94: * the {@code KDF} object, the generated parameters are returned; > 95: * otherwise {@code null} is returned. According to the class spec, when you say parameters are _required_ the caller must provide a non-null value. The sentence above contradicts with this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1759639690
