On Fri, 22 Nov 2024 17:19:31 GMT, Artur Barashev <[email protected]> wrote:
>> SAP complains about SSLSocketNoServerHelloClientShutdown timing out in their
>> test environment (concurrent test execution with high CPU load). This change
>> addresses this issue in 2 ways:
>> - Increase default timeout value
>> - Allow adjustment of timeout value by setting "test.timeout.factor" system
>> property
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adding CountDownLatch mechanism
test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java
line 74:
> 72: float timeoutFactor = Float.parseFloat(
> 73: System.getProperty("test.timeout.factor", "1.0"));
> 74: serverReadTimeout = (int) (30000 * timeoutFactor);
My suggestion was to remove the SoTimeout on both the client and server, also
including the one now at line 95.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22263#discussion_r1854355315
