On Thu, 27 Feb 2025 20:21:28 GMT, Sean Coffey <[email protected]> wrote:
>> Breaking the parent JDK-8044609 JBS issue into sub tasks.
>>
>> This patch addresses the main issue which is that `javax.net.debug=ssl `
>> option is completely broken since TLSv1.3 support was introduced. This
>> patch should be easier for backporting also.
>>
>> Wider corrections can be followed up via parent bug.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Feedback from Mikhail
test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 72:
> 70: "supported_versions"),
> 71: null),
> 72: // ssl should print most details expect verbose details
nit: expect -> except
test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 105:
> 103: "supported_versions"),
> 104: List.of("Plaintext before ENCRYPTION")),
> 105: // ssltypo contains "ssl". Treat like "ssl"
This is surprising behavior. We want it to behave as if there was no suffix
after ssl?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23781#discussion_r1983668452
PR Review Comment: https://git.openjdk.org/jdk/pull/23781#discussion_r1983672768
