On Wed, 20 Aug 2025 15:21:04 GMT, Francesco Andreuzzi <[email protected]> wrote:
>> * test/jdk/sun/security/pkcs11/Provider/ tests skipped without
>> SkippedException:
>> - test/jdk/sun/security/pkcs11/Provider/LoginISE.java
>> - test/jdk/sun/security/pkcs11/Provider/ConfigShortPath.java
>> - test/jdk/sun/security/pkcs11/Provider/Absolute.java
>> * cleanup
>
> test/jdk/sun/security/pkcs11/Provider/LoginISE.java line 47:
>
>> 45: Provider p = Security.getProvider("SunPKCS11");
>> 46: if (p == null) {
>> 47: throw new SkippedException("No un-initialized PKCS11
>> provider available; skip");
>
> Maybe this is not needed anymore, since we are wrapping the message in a
> `SkippedException`
> Suggestion:
>
> throw new SkippedException("No un-initialized PKCS11 provider
> available");
I'd prefer to keep this just to keep the message the same if possible, but yes,
it's the same meaning either way :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26862#discussion_r2288531859
