On Thu, 21 Aug 2025 19:21:06 GMT, Valerie Peng <[email protected]> wrote:
>> This PR is for clarifying the `NoSuchAlgorithmException` and
>> `NoSuchPaddingException` for the `Cipher.getInstance(String transformation,
>> Provider provider)` and `Cipher.getInstance(String transformation, String
>> provider)` methods.
>>
>> As stated in `javax.crypto.CipherSpi` class, provider has the flexibility to
>> register their implementations through various sub-transformations. As a
>> result, depending on how the providers register the implementation, it may
>> lead to `NoSuchAlgorithmException` or `NoSuchPaddingException`. For example,
>> the provider A registers to support "AES/CBC/PKCS5Padding" vs provider B
>> registers to support "AES" (but would only accept "CBC" and "PKCS5Padding"
>> as the valid input for setting mode and padding). Calling
>> `Cipher.getInstance(...)` with "AES/CBC/NoPadding" against provider A and B
>> would lead to `NoSuchAlgorithmException` and `NoSuchPaddingException`. This
>> javadoc update hope to make it clear.
>>
>> Thanks in advance for the review~
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revised the wording again to avoid referring to NoSuchPaddingException
> in NoSuchAlgorithmException
src/java.base/share/classes/javax/crypto/Cipher.java line 609:
> 607: * @throws NoSuchPaddingException if a {@code CipherSpi}
> implementation
> 608: * from the specified {@code provider} is found but it does
> not
> 609: * support the padding scheme
The wording is correct now. Small nit: the NSAE one uses "but does not" and the
NSPE one uses "but it does not". You might want to make them the same.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26489#discussion_r2292085479
