On Thu, 1 May 2025 10:35:55 GMT, Alan Bateman <[email protected]> wrote:
>>> File::getCanonicalPath seems to take the best-effort approach (both in >>> Linux and Windows), whereas Path::toRealPath is stricter. >> >> Path::toRealPath is doing the right thing, and consistent with realpath(2). >> The issue with File::getCanonicalXXX is that it is specified to return a >> canonical file even if it doesn't exist, so this is why you see a lot more >> code to compute a result. >> >> Maybe the recursive include check them maybe it should use the file key >> instead. > >> @AlanBateman are you ok with letting the original >> [c6f1d5f](https://github.com/openjdk/jdk/commit/c6f1d5f374bfa9bde75765391d5dae0e8e28b4ab) >> reviewers know of this fix and take a look? Or do you think further >> discussion is needed somewhere else? > > Have you had time to try using the file key to detect the recursive include > case? Hi @AlanBateman, have you had time to review my previous message? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24465#issuecomment-3242132203
