On Thu, 3 Apr 2025 22:58:39 GMT, Mark Powers <[email protected]> wrote:
> [JDK-8343232](https://bugs.openjdk.org/browse/JDK-8343232) src/java.base/share/classes/sun/security/util/PBKDF2Parameters.java line 67: > 65: * id-hmacWithSHA1 OBJECT IDENTIFIER ::= {digestAlgorithm 7} > 66: */ > 67: public class PBKDF2Parameters { nit: can be marked final? src/java.base/share/classes/sun/security/util/PBKDF2Parameters.java line 72: > 70: ObjectIdentifier.of(KnownOIDs.PBKDF2WithHmacSHA1); > 71: > 72: // AlgorithmIdentifier nit: comment doesn't seem related or useful? Maybe remove? src/java.base/share/classes/sun/security/util/PBKDF2Parameters.java line 77: > 75: private byte[] salt = null; > 76: > 77: private int iterationCount = 0; nit: order the fields matching the ASN.1 definition? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2317061330 PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2317065629 PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2317067786
