On Wed, 3 Sep 2025 14:53:05 GMT, Thomas Fitzsimmons <[email protected]> wrote:

>> Perhaps check the existence of the file and error out with the config file 
>> and its path if the check fails, this way, it's crystal clear.
>
> @valeriepeng I simplified the approach; let me know what you think.  I 
> confirmed I can still configure Kryoptic as needed, though I have to name the 
> `Kryoptic` configuration files `nss/p11-nss.txt` and 
> `nss/p11-nss-sensitive.txt`, which is a little strange.  However this has the 
> advantage of eliminating the need to change any test case arguments.

Yes, I like this approach, it minimizes the changes at the cost of setting up, 
i.e. rename Kryoptic files to match NSS file names. Thanks for this very simple 
approach.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26325#discussion_r2342430961

Reply via email to