On Thu, 18 Sep 2025 09:23:15 GMT, Sean Coffey <[email protected]> wrote:
>> SLSLogger is broken when used with with `System.Logger` (-Djavax.net.debug
>> mode)
>>
>> SSL Debug messages don't use format specifiers. As a result, any custom
>> format data isn't printed. Proposed solution is to append the SSL custom
>> format output to the original debug message. Similar approach used for
>> `SSLConsoleLogger ` mode.
>>
>> Used this opportunity to delete some old commented code and to replace use
>> of `"\n"` with `System.lineSeparator()`
>>
>> DebugPropertyValuesTest also updated to test new logic.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Correct old typo
Since you effectively combine the message and the extra objects, the "expand"
style of log is modified, from
"message" : "Produced ClientHello handshake message",
"specifics" : [
...
]
to
"message" : "Produced ClientHello handshake message:...
Although the current output is no pure legal JSON, the combination makes it
worse if there are quotation marks inside the text for extra objects.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25934#issuecomment-3307810413
