On Wed, 10 Sep 2025 10:57:38 GMT, Mikhail Yankelevich 
<[email protected]> wrote:

>> Tests changed:  
>> * test/jdk/sun/security/pkcs11/Config/ReadConfInUTF16Env.java
>> * test/jdk/sun/security/pkcs11/PKCS11Test.java
>> * test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java
>> * test/jdk/sun/security/pkcs11/Secmod/AddTrustedCert.java
>> * test/jdk/sun/security/pkcs11/Secmod/Crypto.java
>> * test/jdk/sun/security/pkcs11/Secmod/GetPrivateKey.java
>> * test/jdk/sun/security/pkcs11/Secmod/JksSetPrivateKey.java
>> * test/jdk/sun/security/pkcs11/Secmod/LoadKeystore.java
>> * test/jdk/sun/security/pkcs11/Secmod/TestNssDbSqlite.java
>> * test/jdk/sun/security/pkcs11/Secmod/TrustAnchors.java
>> * test/jdk/sun/security/pkcs11/SecmodTest.java
>> * test/jdk/sun/security/pkcs11/ec/ReadCertificates.java
>> * test/jdk/sun/security/pkcs11/ec/ReadPKCS12.java
>> * test/jdk/sun/security/pkcs11/ec/TestKeyFactory.java
>> * test/jdk/sun/security/pkcs11/rsa/KeyWrap.java
>> * test/jdk/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java
>
> Mikhail Yankelevich has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Delete accidental file

test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java line 65:

> 63: 
> 64:     public static void main(String[] args) throws Exception {
> 65:         initSecmod();

Does `initSecmod` ever return false? Should we change the return type to a void 
then?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27166#discussion_r2379035270

Reply via email to