On Wed, 24 Sep 2025 14:03:04 GMT, Sean Mullan <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line
>> 2196:
>>
>>> 2194: String algName =
>>> 2195:
>>> macData.getDigestAlgName().toUpperCase(Locale.ENGLISH);
>>> 2196: if (algName.equals("PBMAC1")) {
>>
>> We should manage to move algorithm-specific logic inside `MacData` as much
>> as possible, ideally everything. For example, instead of letting
>> `macData.getDigestAlgName()` returning either "HmacSHA256" or "PBMAC1", it
>> should return the final `macAlgorithm` we need. If the calculation and
>> verification must be different, they can also be moved into `MacData`.
>
> This makes sense.
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2399650327
