On Thu, 2 Oct 2025 18:06:37 GMT, Mark Powers <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/pkcs12/MacData.java line 190:
>>
>>> 188: var skf = SecretKeyFactory.getInstance(
>>> 189: kdfHmac.equals("HmacSHA512") ?
>>> 190: "PBKDF2WithHmacSHA512" : "PBKDF2WithHmacSHA256");
>>
>> The calculation of mac can be consolidated in one method, which is then
>> called by both `processMacData` and `calculateMac`.
>
> fixed
Is this a game of Whac-A-Mole? I already commented that this is fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2399883749
