Re: RFR: 8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) [v13]

[Weijun Wang]

On Tue, 14 Oct 2025 23:43:39 GMT, Mark Powers <mpow...@openjdk.org> wrote:

>> [JDK-8343232](https://bugs.openjdk.org/browse/JDK-8343232)
>
> Mark Powers has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remaining comments

src/java.base/share/classes/sun/security/pkcs12/MacData.java line 152:

> 150:                     params.getIterationCount(), len);
> 151:             pbeKey = skf.generateSecret(new PBEKeySpec(password,
> 152:                     params.getSalt(), params.getIterationCount(), len));

You already created a variable named `keySpec`. Do not create another exact 
same `PBEKeySpec` object.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2430913964