On Thu, 25 Sep 2025 19:45:48 GMT, Daniel Jeliński <[email protected]> wrote:
> Change SunJSSE to use `TlsUpdateNplus1` instead of `AES` as the key algorithm > when deriving the next application traffic secret. > > SunPKCS11 provider checks the key length when creating an `AES` key, and > since 384 bits is not a valid AES key length, the key creation fails. > > `TlsUpdateNplus1` is [already > recognized](https://github.com/openjdk/jdk/blob/3c9fd7688f4d73067db9b128c329ca7603a60578/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java#L287) > as a standard TLS generic key by SunPKCS11. > > Key update is now exercised by the FipsModeTLS test. The test passes with the > changes, fails without them. Other tier1-3 tests continue to pass. src/java.base/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java line 215: > 213: if (this == TlsKey) > 214: return cs.bulkCipher.algorithm; > 215: return algorithm; nit: how about just `return (this == TlsKey ? cs.bulkCipher.algorithm : algorithm);` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27498#discussion_r2388628833
