On Thu, 2 Oct 2025 20:23:17 GMT, Sean Mullan <[email protected]> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> missed some decoder comments > > src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java line 124: > >> 122: "the given PublicKey"); >> 123: } >> 124: version = V1; > > Why do you set the version to V1 here? There is a public and private key. The issue is EC SEC1v2 uses a V1 version, unlike PKCS#8, but since the original encoding is returned, I can leave version number unchanged. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27147#discussion_r2423065359
