On Wed, 25 Jun 2025 22:08:37 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Text Blocks use \n by default
>
> src/java.base/share/classes/sun/security/ssl/Utilities.java line 154:
>
>> 152: StringBuilder builder = new StringBuilder();
>> 153: if (source == null) {
>> 154: builder.append(LINE_SEP).append(prefix).append("<blank
>> message>");
>
> I don't think this ls covered by the test. Could you please add an empty case
> to cover this?
@myankelev I didn't see any code in the JDK calling this method with `source ==
null`. Other than hacking into the internals of SSLLogger to force the method
call, I'm not sure it can be covered. Would you be ok to log a follow on
task/bug if you feel coverage of this corner case is warranted ? Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25934#discussion_r2367410113
