On Mon, 22 Sep 2025 14:55:15 GMT, Alan Bateman <[email protected]> wrote:
>> The no-arg Thread.stop has been deprecated since JDK 1.2, deprecated for
>> removal since JDK 18, and re-specified to throw UOE unconditionally since
>> JDK 20. It is time to finally remove the method. Its more evil sibling
>> Thread.stop(Throwable) was removed in JDK 11.
>>
>> Code that uses Thread.stop will no longer compile. Code using this method
>> that was compiled to older releases will throw NoSuchMethodError instead of
>> UnsupportedOperationException.
>>
>> Most of the tests using Thread.stop have already been fixed in advance of
>> this PR. However, the tests for Kerberos and DTLS use the KDC server as
>> infrastructure and don't compile because it uses Thread.stop and swallows
>> the UOE. This is tracked by JDK-8360979. It is temporarily changed to use
>> Thread.interrupt to avoid excluding many of tests in these areas. If
>> JDK-8360979 is fixed then no change to KDC is needed.
>
> Alan Bateman has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains three additional
> commits since the last revision:
>
> - Merge branch 'master' into JDK-8368226
> - Update copyright date
> - Initial commit
src/java.base/share/classes/java/lang/ThreadDeath.java line 34:
> 32: * @deprecated {@code Thread} originally specified a "{@code stop}"
> method to stop a
> 33: * victim thread by causing the victim thread to throw a {@code
> ThreadDeath}. It
> 34: * was inherently unsafe and deprecated in an early JDK release. The
> stop method
A trivial issue: it's a method name, so
Suggestion:
* was inherently unsafe and deprecated in an early JDK release. The
{@code stop} method
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27419#discussion_r2373667668
