On Wed, 24 Sep 2025 13:56:01 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> * test/jdk/sun/security/pkcs11/Signature/InitAgainPSS.java >> * test/jdk/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java >> * test/jdk/sun/security/pkcs11/Signature/SigInteropPSS.java >> * test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java >> * test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java >> * test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS2.java >> * test/jdk/sun/security/pkcs11/Signature/TestDSA.java > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > name changes for arrays Changes requested by rhalade (Reviewer). test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java line 146: > 144: mgfHash, > 145: s); > 146: skipTest = true; I think skipTest logic in this test needs further updates. It starts with true as default value, should be false and only set skipTest to true when we encounter a test scenario that is not supported. I think there is also a case where skipTest value is overwritten at line 153 when called in a loop at line 95. ------------- PR Review: https://git.openjdk.org/jdk/pull/27367#pullrequestreview-3371158131 PR Review Comment: https://git.openjdk.org/jdk/pull/27367#discussion_r2456025395
