On Fri, 24 Oct 2025 19:06:33 GMT, Anthony Scarpino <[email protected]> wrote:
>> Hi >> >> Please review the [Second Preview](https://openjdk.org/jeps/8360563) for the >> PEM API. The most significant changes from [JEP >> 470](https://openjdk.org/jeps/470) are: >> >> - Renamed the name of `PEMRecord` class to `PEM`. >> - Revised the new `encryptKey` methods of the `EncryptedPrivateKeyInfo` >> class to accept `DEREncodable` objects rather than just `PrivateKey` objects >> so that cryptographic objects with public keys, i.e., `KeyPair` and >> `PKCS8EncodedKeySpec`, can also be encrypted. >> - Enhanced the `PEMEncoder` and `PEMDecoder` classes to support the >> encryption and decryption of `KeyPair` and `PKCS8EncodedKeySpec` objects. >> >> thanks >> >> Tony > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > more docs, remove runtimeexception src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 434: > 432: * {@code null}, the provider’s default parameters are > applied. > 433: * @param random the {@code SecureRandom} instance used during > encryption. > 434: * If {@code null}, the default is used This method does not include an `@implNote` talking about what "the default" `SecureRandom` means. Shall we just say here that the provider would choose one? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27147#discussion_r2465654061
