On Mon, 27 Oct 2025 23:36:43 GMT, Mark Powers <[email protected]> wrote:
>> [JDK-8343232](https://bugs.openjdk.org/browse/JDK-8343232) > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > A4-A6 from RFC src/java.base/share/classes/sun/security/pkcs12/PBMAC1Parameters.java line 118: > 116: * Encode PBMAC1 parameters from components. > 117: */ > 118: static byte[] encode(byte[] salt, int iterationCount, int keyLength, This is encoding more than the PBMAC1 parameters, it is also encoding the `DigestInfo` structure of the `MacData`. That should really be in the `MacData` class. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2470643646
