On Wed, 26 Nov 2025 21:19:27 GMT, Mark Powers <[email protected]> wrote:
>> Artur Barashev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Fix merge errors >> - Merge branch 'master' into JDK-8371688 >> >> # Conflicts: >> # src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java >> - 8371688: Unexpected behavior for jdk.tls.client.cipherSuites system >> property > > test/jdk/sun/security/ssl/SSLContextImpl/CustomizedCipherSuites.java line 36: > >> 34: * TLS_ECDH_anon_WITH_AES_128_CBC_SHA >> 35: * @run main/othervm >> 36: * -Djdk.tls.client.cipherSuites="unknown" > > I'm assuming these lines were removed because `"unknown"` is the same as `""`. Actually no, this particular test case fails now with this change. I've created `NoSupportedCipherSuites` test to cover that case. > test/jdk/sun/security/ssl/SSLContextImpl/NoSupportedCipherSuites.java line 31: > >> 29: * @test >> 30: * @bug 8371688 >> 31: * @summary Unexpected behavior for jdk.tls.client.cipherSuites system >> property > > Should say client and server properties. Yes, I will update that description, thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28499#discussion_r2566564610 PR Review Comment: https://git.openjdk.org/jdk/pull/28499#discussion_r2566567225
