On Wed, 26 Nov 2025 19:46:38 GMT, Bradford Wetmore <[email protected]> wrote:
>> Could this class could be renamed to something more meaningful? e.g. >> `DHasKEM`, `DHasaKEM` or something similar. A class name of `DH` by itself >> hints this will be a DH implementation. I would expect a `KeyAgreement` >> impl, not as a wrapper. > > One other nit, currently the `Params` class doesn't actually handle `DH`, > just `ECDH`/`XDH`. Should you remove `DH` from the `DH/ECDH/XDH` javadoc? Also, if it is only used by JSSE, I think it should be in the `sun.security.ssl` package. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2577682240
