On Mon, 1 Dec 2025 21:47:29 GMT, Bradford Wetmore <[email protected]> wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/DH.java line 66:
>>
>>> 64: * KEMs.
>>> 65: */
>>> 66: public class DH implements KEMSpi {
>>
>> This class includes more than a DH KEM wrapper implementation. The provider
>> is registering all the hybrid algorithms, including the ML-KEM parts. It
>> feels odd to be hiding the provider inside this class. I suggest creating a
>> separate `HybridProvider` class that is in `sun.security.ssl` package and
>> either encapsulating the DH impl inside that, or better yet, create a
>> separate class for it.
>
> Agreed.
Created a new `HybridProvider` class as suggested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2594591729
