On Mon, 19 Jan 2026 14:01:56 GMT, Ferenc Rakoczi <[email protected]> wrote:
>> The preconditions for the aarch64 and the AVX-512 intrinsic implementations >> of the implKyber12To16() method of com.sun.crypto.provider.ML_KEM are >> different and the AVX-512 one has stricter preconditions on the input, which >> was not recorded in the assert() before calling the function (although they >> were satisfied by all calling code). Now the assert() is corrected, and with >> these preconditions, the aarch64 implementation is simplified. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: > > improve comment This looks good now, thank you. I'm a little unhappy that the initial test did not detect the reads and writes that overflowed the end of, respectively, the input and output arrays. That may indeed be fixed now but it would have been nicer it the test had been able to catch the error. However, I understand that it is hard to achieve that when driving the VM from Java. So, let's hope we don't need any more changes or, if we do, we do our best to ensure (by eyeball) that we don't overshoot the end of the arrays. ------------- Marked as reviewed by adinn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29141#pullrequestreview-3683152734
