On Fri, 6 Mar 2026 17:38:36 GMT, Sandhya Viswanathan <[email protected]> wrote:
>> xinyangwu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changes suggested by sviswa7 > > src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 1436: > >> 1434: const Register len_reg = c_rarg3; // src len (must be multiple of >> blocksize 16) >> 1435: const Register pos = rax; >> 1436: const Register keylen = rbx; > > You could use r11 for keylen, then you don't have to do push/pop rbx. Changed as suggested. > src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 1575: > >> 1573: } //for key_128/192/256 >> 1574: >> 1575: __ BIND(L_exit); > > It will be good to clear all the xmm registers holding the sensitive key > values using pxor before returning from the stub. Thanks for your suggestions. Changed as suggested. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29385#discussion_r2898869145 PR Review Comment: https://git.openjdk.org/jdk/pull/29385#discussion_r2898871202
