On Tue, 10 Mar 2026 19:40:20 GMT, Ben Perez <[email protected]> wrote:

>> Don't be inhibited from changing what I wrote, if it makes sense to do so.
>
> Just pushed an updated version that uses this method of allocating registers. 
> I personally found it more readable to use one `RegSet` and not create new 
> subsets for different scopes. That way each register name is explicitly added 
> and removed when needed. I'm open to changing that though

Sure, I get it. In general it's better to set things up so that the register is 
automagically freed when its declaration scope ends, so there's no need to 
assign to `noreg`. But I can live with it: we've proved by construction that no 
register is accidentally used with two aliases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27946#discussion_r2917203106

Reply via email to