On Thu, 26 Mar 2026 01:18:12 GMT, Weijun Wang <[email protected]> wrote:
>> src/java.base/share/conf/security/java.security line 1750: >> >>> 1748: # stream. It does not affect other supported password sources. For >>> example, >>> 1749: # the JAAS KeyStoreLoginModule allows a password to be read from >>> users-specified >>> 1750: # "keyStorePasswordURL". The keytool and jarsigner commands also >>> support options >> >> Say what type of property this is. > > It's both a system and security property. I look at other properties and they > also only say "the property" or "this property". To clarify, I mean "keyStorePasswordURL", it may not be clear that this is a property. You can simply say the "keyStorePasswordURL" property. >> src/java.base/share/conf/security/java.security line 1751: >> >>> 1749: # the JAAS KeyStoreLoginModule allows a password to be read from >>> users-specified >>> 1750: # "keyStorePasswordURL". The keytool and jarsigner commands also >>> support options >>> 1751: # like "-storepass:env" and "-storepass:file" to read passwords from >>> an >> >> Do you need to say "like"? if these are the only options, just remove "like". > > There are also `-keypass:env` and `-newpass:env` etc. That's why I said > "like". I suggest using "such as" instead of "like" then, since the wording would be a bit more definitive that these are concrete examples. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29490#discussion_r2996231293 PR Review Comment: https://git.openjdk.org/jdk/pull/29490#discussion_r2996211441
