On Tue, 7 Apr 2026 03:04:16 GMT, Mark Powers <[email protected]> wrote:

>> [JDK-8369917](https://bugs.openjdk.org/browse/JDK-8369917)
>
> Mark Powers has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   comment from Ferenc

src/java.base/share/classes/sun/security/provider/DigestBase.java line 250:

> 248:             throws ProviderException {
> 249:         throw new ProviderException("should not be here");
> 250:     }

Usually when we add a new method to an abstract class, the default 
implementation throws an `UnsupportedOperationException`.

Also, now that this is put inside a very base class, please add some detailed 
javadoc explaining the purpose.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29833#discussion_r3046491601

Reply via email to