On Mon, 13 Apr 2026 22:05:26 GMT, Artur Barashev <[email protected]> wrote:
>> RFC 952 specifies that an LDH (Letter-Digit-Hyphen) label may only end with >> a letter or digit. We should remove hyphens from the set of permissible >> terminal characters in a label. >> >> Also see: >> https://www.icann.org/en/announcements/details/comment-concerning-trailing-hyphen-domain-names-7-1-2000-en >> >> Also adding size checks while we touch this file. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Optimize the test. Remove testng dependency. src/java.base/share/classes/sun/security/x509/DNSName.java line 117: > 115: } > 116: > 117: if (label.startsWith("*")) { Maybe we just check `label.equals("*")`? It can always be detected later at the `DNS_ALLOWED.indexOf(c) < 0` check. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30628#discussion_r3102310694
