On Wed, 7 Jan 2026 11:29:56 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Removing silent skips and throwing skipped exceptions in the following tests: >> test/jdk/sun/security/rsa/TestSigGen15.java >> test/jdk/sun/security/rsa/TestCACerts.java >> test/jdk/sun/security/rsa/pss/TestSigGenPSS.java >> test/jdk/sun/security/rsa/pss/SignatureTest2.java >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mikhail Yankelevich has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into JDK-8372817 and update copyright > - JDK-8372817: Remove test/jdk/sun/security/rsa silent skips Changes requested by rhalade (Reviewer). test/jdk/sun/security/rsa/TestCACerts.java line 75: > 73: cert.verify(key, PROVIDER); > 74: } else { > 75: System.out.println("Skipping cert with key: " + alg); Suggestion: System.out.println("Skipping cert with non-RSA key: " + alg); test/jdk/sun/security/rsa/pss/SignatureTest2.java line 184: > 182: if (params == null) { > 183: skippedAlgs.add( > 184: String.format("[digestAlg: %s, digestLen: %d, " + In your test run, did you see this skip happen? This is an intentional skip. If you intend to keep this as skipped then update the log message on line 189 to include `digestAlg`, `digestLen`, `keySize` values to co-relate with skipped exception. ------------- PR Review: https://git.openjdk.org/jdk/pull/28580#pullrequestreview-4190962263 PR Review Comment: https://git.openjdk.org/jdk/pull/28580#discussion_r3155949649 PR Review Comment: https://git.openjdk.org/jdk/pull/28580#discussion_r3155986440
