On Fri, 1 May 2026 16:32:44 GMT, Rajan Halade <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains five >> additional commits since the last revision: >> >> - merge fix >> - Rajan's comment >> - Merge branch 'master' into JDK-8376610 >> - Update test/jdk/javax/net/ssl/TLS/TestJSSE.java >> >> Co-authored-by: Andrey Turbanov <[email protected]> >> - JDK-8376610: Test javax/net/ssl/TLS/TestJSSEClientDefaultProtocol.java >> then completed > > test/jdk/javax/net/ssl/TLS/JSSEServer.java line 74: > >> 72: } >> 73: } catch (Exception e) { >> 74: if (e.getCause() instanceof SocketException && >> closeServer) { > > Suggestion: > > if (e instanceof SocketException && closeServer) { > > > Exception won't have the cause, `SocketException` is thrown directly from > `ServerSocket`. Ah, yes, you're right. Thanks. Fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30538#discussion_r3174121376
