On Fri, 1 May 2026 23:02:05 GMT, Shawn Emery <[email protected]> wrote:
>> This change fixes a flaws in DES[ed]KeySpec::isWeak when passing invalid >> parameters such as negative offsets and null keys. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Shawn Emery has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Merge with master branch > - Preserve existing IKE behavior when key length (with offset) is invalid > - Change throws from IKE to AIOBE for negative offsets > Update javadoc of AIOBE throws > Explicitly check for null keys to provide consitent behavior between > methods > Update null key and offset key unit tests to account for 3DES and AIOBEs > - Add unit test for negative offsets > - 8364121: DESKeySpec.isWeak does not check negative offset Marked as reviewed by mullan (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/30069#pullrequestreview-4236004246
