On Tue, 5 May 2026 19:37:59 GMT, Sean Mullan <[email protected]> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments and new clear()
>
> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line
> 276:
>
>> 274: * @param cipher the initialized {@code Cipher} object which will be
>> 275: * used for decrypting the encrypted data.
>> 276: * @return the PKCS8EncodedKeySpec object with a specified algorithm
>
> What does "with a specified algorithm" mean? "specified" usually means a
> parameter or something related to the API - can you be more specific here?
I'll just remove the change.
> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line
> 519:
>
>> 517: * decryption, or key generation
>> 518: *
>> 519: * @since 25
>
> Change to 27.
This is the same method signature from 25.
> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line
> 570:
>
>> 568: * an error occurs during parsing, decryption, or key
>> generation
>> 569: *
>> 570: * @since 26
>
> Change to 27.
This is the same method signature from 26.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3192048631
PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3192075156
PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3192087755
