On Thu, 7 May 2026 14:54:36 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Adding new methods to `X509Certificate` to return `Instant` instead of >> `Date` as well as moving away from `Date` in internal packages wherever >> possible. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > comments src/java.base/share/classes/java/security/cert/X509Certificate.java line 351: > 349: * > 350: * @return the start date of the validity period. > 351: * @see #checkValidity(Date) I think this means `checkValidity()`. At least the rendered HTML javadoc does so. Same below, the method has the ASN.1 definition which is the ultimate reference. src/java.base/share/classes/java/security/cert/X509Certificate.java line 393: > 391: * Gets the {@code notAfter} date as an {@code Instant} from the > validity > 392: * period of the certificate. > 393: * See {@link #getNotBeforeInstant() getNotBeforeInstant} for > relevant This can be removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r3202738187 PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r3202750411
