On Tue, 14 Apr 2026 09:32:23 GMT, Marcono1234 <[email protected]> wrote:
>> Brent Christian has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into smartcardio
>> - update example code in javax.smartcardio package doc to use try-finally
>> - minor comment update
>> - add missed clean() calls, update comments
>> - fix imports and copyright years
>> - add test case
>> - convert CardImpl finalizer to use Cleaner
>
> src/java.smartcardio/share/classes/sun/security/smartcardio/CardImpl.java
> line 170:
>
>> 168: try {
>> 169: if (e.code == SCARD_W_REMOVED_CARD) {
>> 170: context.state = State.REMOVED;
>
> Related to https://github.com/openjdk/jdk/pull/30683#discussion_r3071989746,
> should instead this here actually de-register the Cleaner?
Yes, done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30683#discussion_r3211548106
