On Mon, 18 May 2026 18:11:01 GMT, Artur Barashev <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Break `ofEncoded(byte[])` intro into 2 sentences >> - Wording improvement: `using the specified hostname` -> `from the >> specified hostname` >> - Wording improvement: `DNS hostname, which is` -> `DNS hostname that is` > > src/java.base/share/classes/javax/net/ssl/SNIHostName.java line 139: > >> 137: * href="http://www.ietf.org/rfc1123.txt";>RFC 1123</a> and <a >> 138: * href="http://www.ietf.org/rfc5280.txt";>RFC 5280</a>) that >> is either >> 139: * ASCII-encoded or an {@linkplain IDN Internationalized Domain >> Name (IDN)}. > > I find this wording confusing, we should make it clear that input must be an > ASCII. How about something like this? > ` > A valid SNI hostname is a DNS hostname (see RFC 1123 and RFC 5280 ) that > is ASCII-encoded. Internationalized Domain Names (IDN) are supported in > ASCII-Compatible Encoding (ACE) form. > ` Oh, nevermind, we do convert it to ASCII. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3261158671
