On Thu, 14 May 2026 14:24:23 GMT, Matthew Donovan <[email protected]> wrote:
>> This timeout may be caused by different code paths used to resolve
>> `InetAddress.getLoopbackAddress()` in the server thread and
>> `factory.createSocket("localhost",...)` in the client thread. I updated the
>> test to use getLoopbackAddress() for both threads.
>>
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - reverted a bunch of changes; changed to use timeout factor for accept()
> call
> - Merge branch 'master' into disable-cipher-suites
> - updated test to enable server thread to exit quickly if client has
> connection error
> - Merge branch 'master' into disable-cipher-suites
> - 8374454: Test
> sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java from
> JDK-8356544 shows intermittent timeouts
Changes requested by azeller (Author).
test/jdk/sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java
line 59:
> 57: private static final CountDownLatch waitForServer = new
> CountDownLatch(1);
> 58: private static final int WAIT_FOR_SERVER_SECS = 5 *
> 59: Integer.getInteger("test.timeout.factor", 1);
test.timeout.factor is given as a float value like 4.0 - this causes this
expression to still be always 5 as it will always take the default of 1.
Perhaps it is easiest to use Utils.adjustTimeout(5) from jdk.test.lib.Utils?
-------------
PR Review: https://git.openjdk.org/jdk/pull/30680#pullrequestreview-4370220407
PR Review Comment: https://git.openjdk.org/jdk/pull/30680#discussion_r3309108317
