On Thu, 4 Jun 2026 05:38:35 GMT, Chen Liang <[email protected]> wrote:
>> I've created a test, should I propose that for the lworld branch to its to >> this PR when sync'ed up? > > Sure! More than pleasured to have you contribute tests to the valhalla repo. > The lworld branch is regularly tested on Oracle's CIs so the earlier the test > gets in on lworld, the more coverage it gets over time. > I made this change, so I could [revert > `test/hotspot/jtreg/vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001.java`](https://github.com/openjdk/jdk/commit/a7ecceb9bd1a99f0674b76a852cc3ab2c25326a4#diff-cbe0d206a08bb013eee2a8cfcc05b7298f91ae960cd17448d2960346295d5c65) > to mainline equivalent. I don't think this is being tested with value > classes unfortunately, seems the existing tests are the ones in jdi around > the test I last modified. The JVMTI function inherited its spec from the older JVMDI spec and needs some TLC. Its implementation is more like Class::getModifiers in it returns the flags from inner_class_access_flags for nested classes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3363649941
