On Tue, 9 Jun 2026 14:10:10 GMT, Sean Mullan <[email protected]> wrote:

>> SunJSSE implementation of `SSLEngine` throws an IllegalStateException if 
>> being used to start a handshake or wrap/unwrap bytes before calling 
>> `setUseClientMode()`. Research shows that it's not necessarily needed and 
>> the `server` default can be used. We do recommend users to set the desired 
>> mode explicitly in `SSLContext` and `SSLContextSpi` javadocs.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/java.base/share/classes/sun/security/ssl/TransportContext.java line 133:
> 
>> 131:     private TransportContext(SSLContextImpl sslContext, SSLTransport 
>> transport,
>> 132:             SSLConfiguration sslConfig, InputRecord inputRecord,
>> 133:             OutputRecord outputRecord, boolean existingSSLConfig) {
> 
> Do you need the `existingSSLConfig` param? The previous code looked fine, 
> where the config is cloned before calling the ctor.

I need this to avoid constructors signatures collision. Basically, it's just a 
little trick to keep constructors signatures unchanged.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31422#discussion_r3381448855

Reply via email to